Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc fixes #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

misc fixes #36

wants to merge 4 commits into from

Conversation

delthas
Copy link

@delthas delthas commented Jul 8, 2020

some fixes i had to add to make irctest work for my ircd.

running the tests on non-oragono servers is broken right now, even with these fixes, because some test cases with oragono tests still call setUp, tearDown that end up calling oragono-specific functions on the controllers, like baseConfig and addMysqlToConfig.

as a hotfix i added to my controller:

    def baseConfig(self):
        return {}

    def addMysqlToConfig(self, config=None):
        pass

also changed the run function to:

 def run(self, hostname, port, password=None, ssl=False,
            restricted_metadata_keys=None,
            valid_metadata_keys=None, invalid_metadata_keys=None, config=None):

because the tests need the config parameter even though it's oragono specific stuff.

so yeah the project is kinda broken for non-oragono servers anyways but here's some fixes for issues i had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant