Empty conditions should be [], but not {}

DanielVartanov · May 20, 2010 · e4af210 · e4af210
1 parent 59a9031
commit e4af210
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/test/unit/conditions_builder_spec.rb b/test/unit/conditions_builder_spec.rb
@@ -40,11 +40,11 @@
     end
 
     it "should return empty hash is arguments are invalid" do
-      ConditionsBuilder.build_conditions(nil, :gt, 1).should == {}
-      ConditionsBuilder.build_conditions('field', :invalid_relation, 1).should == {}
-      ConditionsBuilder.build_conditions('field', :gt).should == {}
-      ConditionsBuilder.build_conditions('field', :gt, 'value', 'redundant_value').should == {}
-      ConditionsBuilder.build_conditions('field', :between, 'insufficient value').should == {}
+      ConditionsBuilder.build_conditions(nil, :gt, 1).should == []
+      ConditionsBuilder.build_conditions('field', :invalid_relation, 1).should == []
+      ConditionsBuilder.build_conditions('field', :gt).should == []
+      ConditionsBuilder.build_conditions('field', :gt, 'value', 'redundant_value').should == []
+      ConditionsBuilder.build_conditions('field', :between, 'insufficient value').should == []
     end
 
     def quoted(column_name)

diff --git a/test/unit/predicate_spec.rb b/test/unit/predicate_spec.rb
@@ -30,15 +30,17 @@
   end
 
   describe "predicate string is invalid" do
+
     it "should not accept unrecognized format" do
       @predicate = Predicate.parse('blah-blah-blah')
       ConditionsBuilder.should_not_receive :build_conditions
-      @predicate.to_conditions.should == {}
+      @predicate.to_conditions.should == []
     end
+
     it "should not accept non-quote-marked empty string" do
       @predicate = Predicate.parse('born_at gt ')
       ConditionsBuilder.should_not_receive :build_conditions
-      @predicate.to_conditions.should == {}
+      @predicate.to_conditions.should == []
     end
   end
 end