Skip to content
This repository has been archived by the owner on Mar 11, 2023. It is now read-only.

Properly tested config detection #117

Merged
merged 1 commit into from Feb 5, 2017
Merged

Conversation

DanielaSfregola
Copy link
Owner

@DanielaSfregola DanielaSfregola commented Feb 5, 2017

Although this lowers down the test coverage, it makes tests independent from the env variables set up on the machine when running tests.

@DanielaSfregola DanielaSfregola added this to the 5.0 milestone Feb 5, 2017
@codecov
Copy link

codecov bot commented Feb 5, 2017

Codecov Report

Merging #117 into master will increase coverage by -0.94%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   93.37%   92.44%   -0.94%     
==========================================
  Files          60       60              
  Lines        1057     1059       +2     
  Branches       12       11       -1     
==========================================
- Hits          987      979       -8     
- Misses         70       80      +10
Impacted Files Coverage Δ
...clients/rest/favorites/TwitterFavoriteClient.scala 100% <ø> (ø)
.../danielasfregola/twitter4s/TwitterRestClient.scala 0% <ø> (-100%)
...elasfregola/twitter4s/TwitterStreamingClient.scala 0% <ø> (-100%)
...anielasfregola/twitter4s/util/Configurations.scala 66.66% <50%> (+16.66%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63589d5...cdb7dca. Read the comment docs.

@DanielaSfregola
Copy link
Owner Author

LGTM

@DanielaSfregola DanielaSfregola merged commit 599d081 into master Feb 5, 2017
@DanielaSfregola DanielaSfregola deleted the test_config_improvements branch February 5, 2017 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant