Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added QuietDrift support for Curtain 3 #223

Merged
merged 8 commits into from Dec 20, 2023

Conversation

den-mko
Copy link
Contributor

@den-mko den-mko commented Dec 15, 2023

Added speed to open, close and set_position methods. "00" or "ff" - normal, "01" - slow #222

switchbot/devices/curtain.py Outdated Show resolved Hide resolved
switchbot/devices/curtain.py Outdated Show resolved Hide resolved
@bdraco
Copy link
Collaborator

bdraco commented Dec 18, 2023

I adjusted the code a bit to make it easier to follow.

Please retest. I'll merge it and do a release if it works as expected

To match _send_multiple_commands function type
@den-mko
Copy link
Contributor Author

den-mko commented Dec 20, 2023

Small typing fix. Tested successfully.

@bdraco bdraco merged commit fe687c3 into Danielhiversen:master Dec 20, 2023
4 checks passed
@Brephlas
Copy link

There is still a pull request needed to upgrade the integration in the HA core similar to this one, right?
@den-mko Do you want to create one? If not, I could do that too

@den-mko
Copy link
Contributor Author

den-mko commented Dec 26, 2023

I already wrote the code with curtains speed changing features but did not have time to submit a PR. Will try to submit it tomorrow

@lightheaded
Copy link

It has now been incorporated into HA core. How would one go about using quietdrift now?

@quenthal
Copy link

quenthal commented Jan 9, 2024

I already wrote the code with curtains speed changing features but did not have time to submit a PR. Will try to submit it tomorrow

Is it already in your fork?

@quizzical86
Copy link

@den-mko would you happen to have any news on enabling support for quietdrift?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants