Add support for data with zero values from WoSensorTH #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
reviewed
Jan 24, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 51.28% 51.38% +0.10%
==========================================
Files 33 33
Lines 1441 1444 +3
==========================================
+ Hits 739 742 +3
Misses 702 702 ☔ View full report in Codecov by Sentry. |
bdraco
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support processing data with zero values from WoSensorTH. I have experienced that when the power supply is not stable, the meter would advertise zero values and its screen would be flashing. This PR is to ignore those zero values as if no data is received.
Test case is added for the above case.