Refactored common curtain/tilt code to shared base class

[dcmeglio]

This is still a WIP (haven't tested at all yet except running existing unit tests) but wanted to see if this was along the lines you were thinking before I go too far down this road.

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7894a85) 51.38% compared to head (3cd8503) 58.59%.

Files	Patch %	Lines
switchbot/devices/blind_tilt.py	96.15%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   51.38%   58.59%   +7.21%     
==========================================
  Files          33       34       +1     
  Lines        1444     1495      +51     
==========================================
+ Hits          742      876     +134     
+ Misses        702      619      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

Seems like a reasonable path forward

[dcmeglio]

Other than that assumed bug which I'm now almost positive about looking at get_extended_info_adv I've added code coverage and unit tests for my changes. I'm going to work on some formatting cleanups and also still need to test with some actual devices. Otherwise I think this should fix the issue.

[bdraco]

You can probably do

isort switchbot
black switchbot
ruff --fix switchbot

[bdraco]

I'll test this tomorrow

[dcmeglio]

My tilt won't be here for a few days so I can't test that, but my curtains still work fully and the is_opening/is_closing are still fine too. I'm going to consider this ready for review. Let me know how your testing goes. It should just require a version bump in HA.

Technically this is a breaking change in the API since the base class for the Tilt has been changed? If someone was relying on Tilt inheriting from Curtain, this will now cause an issue.

[bdraco]

Technically this is a breaking change in the API since the base class for the Tilt has been changed? If someone was relying on Tilt inheriting from Curtain, this will now cause an issue.

That's a stretch for a breaking change. Should be ok

[dcmeglio]

People are reporting it still happens with this code. I’m not spotting the issue right now. Might have to wait till my tilt arrives

[bdraco]

I did some adjustments. I think the blind tilt now has all the previous methods so it should work now

[bdraco]

Device just showed up

Charging it now

Will test shortly.

[bdraco]

Its working with the latest changes I pushed

[bdraco]

Thanks @dcmeglio