Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers are not being applied #60

Closed
clouedoc opened this issue Feb 15, 2022 · 3 comments
Closed

Headers are not being applied #60

clouedoc opened this issue Feb 15, 2022 · 3 comments

Comments

@clouedoc
Copy link

Actual behavior

Headers specified in cycletls.Options are not applied using the Go library.

Expected behavior

https://httpbin.org/headers should return the additional header (foo)

To Reproduce Steps to reproduce the behavior

r, err := client.Do("https://httpbin.org/headers", cycletls.Options{
		Ja3:       fp.Ja3,
		UserAgent: fp.UserAgent,
		Headers:   map[string]string{
                     "foo": "bar",
                },
	}, opts.Method)

Additional Information

  • Operating System information: Darwin Big Sur 11.6
  • Node version: N/A
  • Golang version: go1.17.6 darwin/arm64

go.mod

github.com/Danny-Dasilva/CycleTLS/cycletls v0.0.0-20220211211237-3f5cc5690340 // indirect
github.com/Danny-Dasilva/fhttp v0.0.0-20211010093114-56fde831fe2f // indirect
@Danny-Dasilva
Copy link
Owner

Great catch, should be fixed in the latest release 0.0.16. I added tests to cover this as well.

@clouedoc
Copy link
Author

@89z @Danny-Dasilva

Thank you for both of your answers 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@clouedoc @Danny-Dasilva and others