Improve JSON schema tests #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #466
This PR adds the necessary infrastructure for easily ensuring that invalid JSON schemas fail as expected.
For the time being, there is one single YAML file for each of the schemas (settings, strings, bashly).
As expected, the bashly schema fails. When it passes, we should probably add at least a handful more test files.
spec/fixtures/schema_invalidfolder, with subfolder-name-as-schema convention, and with test YAMLs in each.run schema invalidtest command that tests all invalid fixtures inspec/fixtures/schemas_invalidrun schema allto include the invalid tests.