$_WD_SupportedBrowsers should be const

[mlipok]

Pull request

Proposed changes

Code CleanUp and Good Coding practice

Checklist

• I have read and noticed the CODE OF CONDUCT document
• I have read and noticed the CONTRIBUTING document
• I have added necessary documentation or screenshots (if appropriate)

Types of changes

• Bugfix (change which fixes an issue)
• Feature (change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (functional, structural)
• Documentation content changes
• Other (please describe)

What is the current behavior?

$_WD_SupportedBrowsers is declared as Global

What is the new behavior?

$_WD_SupportedBrowsers is declared as Global Const

$_WD_BROWSER was moved as they are related to $_WD_SupportedBrowsers

$_WD_ERROR_COUNTER is renamed to $_WD_ERROR__COUNTER I mean there was added underscore to have better InteliCode support. I mean $_WD_ERROR_COUNTER is not normal variable and should not be used by user thus, typing ``$_WD_ERROR_Cshould not popup this variable byInteliCode` engine, especially when especially for the new upcoming version of SciTE4AutoIt3.

Additional context

none

System under test

not related

[Danp2]

$_WD_SupportedBrowsers is declared as Global Const

Fine

$_WD_BROWSER was moved as they are related to $_WD_SupportedBrowsers

Ok

$_WD_ERROR_COUNTER is renamed to $_WD_ERROR__COUNTER

Wouldn't the "standard" here be to put the double underscore at the front instead of in the middle (ie: $__WDVERSION)?

[mlipok]

Wouldn't the "standard" here be to put the double underscore at the front instead of in the middle (ie: $__WDVERSION)?

I think no.
Because the prefix $_WD_ERROR_******* should be the same.
This is kind of reminder something like Hey this $_WD_ERROR__COUNTER be used as they are used only internally by the UDF.

So using InteliSens

to use them you should press underscore twice

Using single underscore it also be listed but not in the middle

but at the end

Leaving them like I proposed it is still visible in the same prefixed $_WD_ERROR_ group of variables, and as this is on the end this is good ..... as for me ;)