SetupEdge - user-data-dir - admin support #452
Conversation
|
Should we also add relevant changes for other browsers ? |
There was a problem hiding this comment.
IMO, this shouldn't be added as "default" functionality just because MSEdge is misbehaving when run under Admin privileges. I would recommend making the following changes --
- Comment out this line by default
- Add a comment block explaining that the line should be uncommented if issues are encountered when running the demo script under Admin privileges.
|
Maybe check if is admin .. ? |
That's an option. However, I suggest that we take a step back and analyze the purpose of wd_demo. IMO, it is designed to demonstrate some of the basic functionality of the WD UDF. It isn't designed to handle every possible scenario or strange configuration that someone can throw at it. There are obvious times where exceptions are made. One example is where the 'binary' option was added to the Capabilities string to avoid issues with 32-bit versions of some webdrivers. This is a common error that could occur, so it made sense to include the fix. I'm not so sure that this current issue would fall into that same category of commonly occurring. Until today, I've never run wd_demo with #requireadmin, and I highly doubt that others need this functionality in this demo script. |
|
So this behavior is by design per Microsoft. Also, further testing has shown that this change doesn't actually fix the issue, |
Pull request
Proposed changes
Add support for runing MS EDGE with elevated to admin
#RequireAdminChecklist
Types of changes
What is the current behavior?
using SetupEdge with elevation to Admin will hit error
What is the new behavior?
works properly
Additional context
https://www.autoitscript.com/forum/topic/210071-webdriver-and-admin-rights
https://www.autoitscript.com/forum/topic/210071-webdriver-and-admin-rights/?do=findComment&comment=1516684
System under test
MS EDGE