Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding validation to check if style object is null #49

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Adding validation to check if style object is null #49

merged 2 commits into from
Nov 28, 2018

Conversation

ptoc-xumak
Copy link
Contributor

Adding validation to check if style object is null

ehernandez-xk
ehernandez-xk requested changes Nov 27, 2018
View reviewed changes
Copy link
Member

@ehernandez-xk ehernandez-xk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, would you please update the CHANGELOG file?

ehernandez-xk
ehernandez-xk approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@ehernandez-xk ehernandez-xk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehernandez-xk ehernandez-xk merged commit f8e4ecf into DantaFramework:master Nov 28, 2018
@ehernandez-xk ehernandez-xk mentioned this pull request Nov 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehernandez-xk ehernandez-xk ehernandez-xk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptoc-xumak @ehernandez-xk