Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved images and icons support #1

Merged

Conversation

Danziger
Copy link
Owner

@Danziger Danziger commented Aug 9, 2018

Adds support for:

  • Notifications with images
  • Alpha-only icons for Android Lollipop or greater.
  • Icon/title color for Android Lollipop or greater.

Partially fixes theTransactionTooLargeException / FAILED BINDER TRANSACTION error (for non-scheduled notifications).

It also cleans up some existing duplicated, unused and/or debugging code.

…alpha-only icons for Android Lollipop or greater and icon/title color and partially fixes the TransactionTooLargeException / FAILED BINDER TRANSACTION error. It also cleans up some existing duplicated code.
@Danziger Danziger self-assigned this Aug 9, 2018
@Danziger Danziger changed the title [WIP] Improved images and icons support Improved images and icons support Aug 21, 2018
@Danziger Danziger merged commit 50c5bff into master Aug 21, 2018
return (settings.types & types) > 0;
}

private static guid() {
// Not the best, but will it will do. See https://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"but will it will do"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants