Skip to content

Commit

Permalink
Bumping dependencies version numbers
Browse files Browse the repository at this point in the history
  • Loading branch information
@sebastienros
sebastienros committed Apr 4, 2016
1 parent 92eca47 commit 70ee9a7
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions Dapper/project.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@
"dependencies": {
"Microsoft.CSharp": "4.0.1-*",
"System.Collections": "4.0.11-*",
"System.Collections.Concurrent": "4.0.11-*",
"System.Collections.Concurrent": "4.0.12-*",
"System.Collections.NonGeneric": "4.0.1-*",
"System.Data.SqlClient": "4.0.0-*",
"System.Linq": "4.0.1-*",
"System.Data.SqlClient": "4.1.0-*",
"System.Linq": "4.1.0-*",
"System.Reflection.Emit.ILGeneration": "4.0.1-*",
"System.Reflection.Emit.Lightweight": "4.0.1-*",
"System.Reflection.TypeExtensions": "4.1.0-*",
"System.Runtime": "4.0.21-*",
"System.Text.RegularExpressions": "4.0.11-*",
"System.Runtime": "4.1.0-*",
"System.Text.RegularExpressions": "4.0.12-*",
"System.Threading": "4.0.11-*",
"System.Threading.ThreadPool": "4.0.10-*",
"System.Xml.XDocument": "4.0.11-*",
Expand Down

7 comments on commit 70ee9a7

@mgravell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sebastienros - trying this locally with just the regular nuget feed (https://api.nuget.org/v3/index.json), I get:

D:\Dev\dapper-dot-net\Dapper>dotnet restore
info : Restoring packages for D:\Dev\dapper-dot-net\Dapper\project.json...
error: Unable to resolve System.Text.RegularExpressions (>= 4.0.12) for .NETPlatform,Version=v5.4.
error: Unable to resolve System.Collections.Concurrent (>= 4.0.12) for .NETPlatform,Version=v5.4.
error: Unable to resolve System.Linq (>= 4.1.0) for .NETPlatform,Version=v5.4.
error: Unable to resolve System.Data.SqlClient (>= 4.1.0) for .NETPlatform,Version=v5.4.
error: Unable to resolve System.Runtime (>= 4.1.0) for .NETPlatform,Version=v5.4.
info : Committing restore...
info : Restore failed in 842ms.

If I add nuget + https://www.myget.org/F/aspnetvnext/ I get:

D:\Dev\dapper-dot-net\Dapper>dotnet restore
info : Restoring packages for D:\Dev\dapper-dot-net\Dapper\project.json...
info : Installing System.Xml.XmlDocument 4.0.1-rc2-23931.
info : Installing System.Threading.ThreadPool 4.0.10-rc2-23931.
info : Installing System.Xml.XDocument 4.0.11-rc2-23931.
info : Installing System.Threading 4.0.11-rc2-23931.
info : Installing System.Runtime 4.1.0-rc2-23931.
info : Installing System.Reflection.Emit.ILGeneration 4.0.1-rc2-23931.
info : Installing System.Data.SqlClient 4.1.0-rc2-23931.
info : Installing System.Reflection.TypeExtensions 4.1.0-rc2-23931.
info : Installing System.Reflection.Emit.Lightweight 4.0.1-rc2-23931.
info : Installing System.Collections.NonGeneric 4.0.1-rc2-23931.
info : Installing System.Linq 4.1.0-rc2-23931.
info : Installing System.Collections 4.0.11-rc2-23931.
info : Installing Microsoft.CSharp 4.0.1-rc2-23931.
info : Installing System.Collections.Concurrent 4.0.12-rc2-23931.
info : Installing System.Text.RegularExpressions 4.0.12-rc2-23931.
error: System.Text.RegularExpressions 4.0.12-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Collections.Concurrent 4.0.12-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: Microsoft.CSharp 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Collections 4.0.11-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Linq 4.1.0-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Collections.NonGeneric 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Reflection.Emit.Lightweight 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Reflection.TypeExtensions 4.1.0-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Data.SqlClient 4.1.0-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Reflection.Emit.ILGeneration 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Runtime 4.1.0-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Threading 4.0.11-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Xml.XDocument 4.0.11-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Threading.ThreadPool 4.0.10-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Xml.XmlDocument 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: Some packages are not compatible with .NETPlatform,Version=v5.4.
info : Committing restore...
info : Restore failed in 3442ms.

If I instead reset the cache and add nuget + https://www.myget.org/F/dotnet-coreclr/api/v3/index.json I get:

D:\Dev\dapper-dot-net\Dapper>dotnet restore
info : Restoring packages for D:\Dev\dapper-dot-net\Dapper\project.json...
error: Unable to resolve System.Collections.Concurrent (>= 4.0.12) for .NETPlatform,Version=v5.4.
error: Unable to resolve System.Text.RegularExpressions (>= 4.0.12) for .NETPlatform,Version=v5.4.
error: Unable to resolve System.Data.SqlClient (>= 4.1.0) for .NETPlatform,Version=v5.4.
error: Unable to resolve System.Linq (>= 4.1.0) for .NETPlatform,Version=v5.4.
error: Unable to resolve System.Runtime (>= 4.1.0) for .NETPlatform,Version=v5.4.
info : Committing restore...
info : Restore failed in 5613ms.

If I reset the cache and add all 3, I get:

D:\Dev\dapper-dot-net\Dapper>dotnet restore
info : Restoring packages for D:\Dev\dapper-dot-net\Dapper\project.json...
info : Installing System.Collections.NonGeneric 4.0.1-rc2-23931.
info : Installing System.Threading.ThreadPool 4.0.10-rc2-23931.
info : Installing System.Threading 4.0.11-rc2-23931.
info : Installing System.Collections.Concurrent 4.0.12-rc2-23931.
info : Installing System.Linq 4.1.0-rc2-23931.
info : Installing System.Xml.XmlDocument 4.0.1-rc2-23931.
info : Installing System.Text.RegularExpressions 4.0.12-rc2-23931.
info : Installing System.Reflection.TypeExtensions 4.1.0-rc2-23931.
info : Installing System.Collections 4.0.11-rc2-23931.
info : Installing System.Xml.XDocument 4.0.11-rc2-23931.
info : Installing System.Runtime 4.1.0-rc2-23931.
info : Installing System.Data.SqlClient 4.1.0-rc2-23931.
info : Installing System.Reflection.Emit.ILGeneration 4.0.1-rc2-23931.
info : Installing System.Reflection.Emit.Lightweight 4.0.1-rc2-23931.
info : Installing Microsoft.CSharp 4.0.1-rc2-23931.
error: Microsoft.CSharp 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Reflection.Emit.Lightweight 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Reflection.Emit.ILGeneration 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Data.SqlClient 4.1.0-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Runtime 4.1.0-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Xml.XDocument 4.0.11-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Collections 4.0.11-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Reflection.TypeExtensions 4.1.0-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Text.RegularExpressions 4.0.12-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Xml.XmlDocument 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Linq 4.1.0-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Collections.Concurrent 4.0.12-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Threading 4.0.11-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Threading.ThreadPool 4.0.10-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: System.Collections.NonGeneric 4.0.1-rc2-23931 is not compatible with .NETPlatform,Version=v5.4.
error: Some packages are not compatible with .NETPlatform,Version=v5.4.
info : Committing restore...
info : Restore failed in 8277ms.

I'm not sure which set of errors I should prefer!

Basically, as an external non-MS person, what am I missing about how to build this? Because: it doesn't seem to work. If I can't figure it out, I'll have to revert the commit.

@sebastienros
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's because I am using the latest CLI ... I will ask the experts.

@sebastienros
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, the change I made is only compatible with rc2. Which means it also depends on using netstandard1.3 in your case.
These packages are not yet on nuget.org as a matter of fact.

@mgravell
Copy link
Member

@mgravell mgravell commented on 70ee9a7 Apr 6, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastienros
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollback. My mistake, I am very sorry I didn't think about it, using rc2 only for the past month now I hadn't thought about it. And I had to apply these changes on my library to override your own versions.
What I can do is work on a branch with everything for RC2, that you can try and merge when you want to.

@mgravell
Copy link
Member

@mgravell mgravell commented on 70ee9a7 Apr 6, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgravell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted for now: 99e3287

The change is very much appreciated - just... it breaks everything right now!

Please sign in to comment.