Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SqlDataRecord TVPs on corefx. #801

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

sergiivolchkov
Copy link
Contributor

Dapper's support for passing TVPs as IEnumerable<SqlDataRecord> (contrary to DataTable) using SqlMapper.AsTableValuedParameter or type handlers seem to work perfectly fine on .net core 1.x (tested on 1.1.2 runtime).

One caveat here is that Dapper dependency on System.Data.SqlClient has to be brought back.

@NickCraver
Copy link
Member

This is already underway in the https://github.com/StackExchange/Dapper/tree/netstandard2 branch, just waiting on an updated SqlClient preview and Appveyor support before we can merge in and get builds going. The netstandard1.x support will be some ifdef changes, but it's going to be much cleaner to do that after the branch merge. Or if you want to PR against that branch today I'd happily pull and test/accept it :)

@sergiivolchkov
Copy link
Contributor Author

See #802 :)

@NickCraver
Copy link
Member

@sergiivolchkov looking good - thanks for the rebase! We'll try and get this merged in very soon, the netstandard2.0 build blocker on Appveyor is our current issue, but they've got an image so I hope to get it building right this week and merge down into master overall. No problem yanking this into the 2.0 branch as-is while I work on the overall merge though, here we go!

@NickCraver NickCraver merged commit e7ad087 into DapperLib:master Jun 15, 2017
NickCraver added a commit that referenced this pull request Jun 15, 2017
NickCraver added a commit that referenced this pull request Jun 15, 2017
@NickCraver
Copy link
Member

Doh, wrong PR - meant to merge #802 and had the wrong tab - merging there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants