SubGhz some improvements #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gid9798
commented
May 13, 2023
| return true; | ||
| }, | ||
| true); | ||
| subghz_transmitter->callback( |
There was a problem hiding this comment.
You can add a check here so that other buttons don't send the original signal. This is useful if there are no custom buttons in the protocol.
xMasterX
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
SubGhz app: removed duplicate code in
transmitter.cSubGhz app: fix "add manual" Alutech AT 4N
SubGhzRemote app: drop include from SubGhz app
SubGhz: Improved code readability and some "if" optimization in custom button and keeloq
Fix strange bug with formatting in VS CODE in
keeloq.candstar_line.cVerification
Checklist (For Reviewer)