Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction on readme for development setup #19

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Correction on readme for development setup #19

merged 1 commit into from
Dec 7, 2022

Conversation

jubalm
Copy link
Collaborator

@jubalm jubalm commented Dec 6, 2022

The vendor directory is not present on clone and errors out during Load unpacked step during setup on Chrome. Running npm run vendor before build fixes the issue.

MicahZoltu
MicahZoltu approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also missing the build step for the inpage. We can merge this as is though as it is strictly better than current instructions!

@MicahZoltu MicahZoltu mentioned this pull request Dec 7, 2022
Closed
@KillariDev
Copy link
Contributor

this is not a mandatory step, as the js code's are in the repo. Its mandatory if you change those files thought.

@KillariDev KillariDev merged commit d024d15 into DarkFlorist:main Dec 7, 2022
@MicahZoltu
Copy link
Contributor

vendor folder isn't checked in, it is in the .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicahZoltu MicahZoltu MicahZoltu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jubalm @KillariDev @MicahZoltu