Simple readonly top 100 addresses prototype address book and new way to move data between backround page and popups #88
Conversation
| "funtypes": "../vendor/funtypes/index.mjs", | ||
| "node-fetch": "../vendor/node-fetch/index.mjs", | ||
| "@zoltu/ethereum-abi-encoder": "../vendor/@zoltu/ethereum-abi-encoder/index.js", | ||
| "@zoltu/ethereum-crypto": "../vendor/@zoltu/ethereum-crypto/index.js", |
There was a problem hiding this comment.
We should consider moving away from @zoltu/ethereum-crypto. There may also be better alternatives to rlp-encoder and abi-encoder as well that could be worth investigating.
There was a problem hiding this comment.
created an issue to look into that
extension/app/html/addressBook.html
Outdated
| <main>Loading...</main> | ||
|
|
||
| <!-- a workaround for bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1803984 --> | ||
| <script type = 'module'>import '../js/addressBookRender.js'</script> |
There was a problem hiding this comment.
| <script type = 'module'>import '../js/addressBookRender.js'</script> | |
| <script async type = 'module'>import '../js/addressBookRender.js'</script> |
extension/app/ts/AddressBook.tsx
Outdated
| </a> | ||
| } | ||
|
|
||
| export function AddressList(param: { addressBookEntries: AddressBookEntries | undefined }) { |
There was a problem hiding this comment.
Consider destructuring here so you don't have to do param. everywhere.
| export function AddressList(param: { addressBookEntries: AddressBookEntries | undefined }) { | |
| export function AddressList({addressBookEntries}: { addressBookEntries: AddressBookEntries | undefined }) { |
extension/app/ts/AddressBook.tsx
Outdated
| const [addressBookEntries, setAddressBookEntries] = useState<AddressBookEntries | undefined>(undefined) | ||
| const activeFilterRef = useRef<ActiveFilter>(activeFilter) | ||
|
|
||
| useEffect( () => { |
There was a problem hiding this comment.
Style consistency I think? You have been doing this a lot lately, maybe it is intentional and the goal is to change the style to include a space here? I'm not a big fan because it goes against the general style of "no space after parenthesis", but I'm open to having my mind changed.
| useEffect( () => { | |
| useEffect(() => { |
There was a problem hiding this comment.
is not intentiol :D
window.interceptor, the plan is to change all popups to communicate like this, so we can get rid of the globalwindow.interceptoreventually