Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration #1

Merged
merged 7 commits into from
Sep 16, 2019

Conversation

williamjameshandley
Copy link
Member

I've updated the continuous integration and test framework, in particular

  • Code is now PEP8 compliant
  • I removed tests/test_lint.py in lieu of running flake8 in the travis integration. This is better because it doesn't need to run the entire test suite before checking for pep8 compliance.
  • Reduced to only testing python 3.6 on linux. More can be added, but there are issues attached to matplotlib for python < 3.6

@williamjameshandley
Copy link
Member Author

It might also be wise to block people pushing to the master branch on the repository to prevent clashes as multiple people update either the paper or the framework.

@bstienen
Copy link
Member

Thanks! I have never worked with travis before, I hope to understand what the things you changed do exactly at the end of the day. If, in the mean time, you know how to fix the "The command "flake8 high_dimensional_sampling tests" failed and exited with 1 during ." error in travis, help would be greatly appreciated.

It might also be wise to block people pushing to the master branch on the repository to prevent clashes as multiple people update either the paper or the framework.

Good idea. I have blocked pushing to master.

@bstienen
Copy link
Member

Okay i figured it out :-). I am glad it is not as complicated as i feared ^^

@bstienen bstienen merged commit 28b4da3 into DarkMachines:master Sep 16, 2019
bstienen pushed a commit that referenced this pull request Feb 24, 2020
bstienen added a commit that referenced this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants