Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor workflow simplifications #144

Merged
merged 2 commits into from Oct 31, 2023

Conversation

TSRBerry
Copy link
Contributor

@TSRBerry TSRBerry commented Oct 31, 2023

This PR is a follow up from DarkMatterCore/libusbhsfs#29 and simplifies the existing workflow a tiny bit.

I told you about some improvements quite a while ago and never got around to PR them. It seems someone else also found improvements, so the changes I made aren't as significant.

Some notes about the changes I made:

A few other improvements that could be made, but I didn't want to include here:

  • Using ccache with GitHub Actions cache to speed up compilations (like ldn_mitm)
  • Using releases for libusbhsfs and installing them in the workflow instead of compiling it there
  • Using the libnx library that's already present in the dkp image and falling back to the latest commit if the first build attempt fails (similar to ldn_mitm)

Workflow run using my libusbhsfs changes: https://github.com/TSRBerry/nxdumptool/actions/runs/6709816685/job/18233685461
Although it fails in the end this seems to be unrelated to my changes.

@DarkMatterCore
Copy link
Owner

Thanks! I'll take a better look at this after I get back home.

@DarkMatterCore
Copy link
Owner

Looks good to me. Thanks again. :)

@DarkMatterCore DarkMatterCore merged commit ec6deed into DarkMatterCore:rewrite Oct 31, 2023
@TSRBerry TSRBerry deleted the simplify-workflow branch October 31, 2023 23:52
DarkMatterCore added a commit that referenced this pull request Apr 15, 2024
Based on the suggestions mentioned by @TSRBerry in #144.

Speeds up compilation time by using ccache + fallbacks to the latest libnx commit if the build process fails with the libnx build available in the devkitPro image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants