Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler Auto Crafting Stage-Gate Barrier #1803

Closed
Soaryn opened this issue Apr 14, 2018 · 14 comments
Closed

Assembler Auto Crafting Stage-Gate Barrier #1803

Soaryn opened this issue Apr 14, 2018 · 14 comments

Comments

@Soaryn
Copy link

Soaryn commented Apr 14, 2018

Issue / Bug

https://clips.twitch.tv/WonderfulGentleWormDoritosChip
Similar to the issue of #1733 but poses more of a automation barrier for some setups.

Expected Behavior

Assembler from Immersive Engineering is an auto crafting table for 3 different items at a time. Should be able to craft things the player knows about (POSSIBLY more)

Possible Solution

If there is a way to link a specific assembler to a player. Be careful merely whitelisting the fake player as it is a crafting bench and COULD craft things gated farther than the player.
If it is not a unique fake player per Assembler, then I would recommend syncing it to the farthest player on the server.

Steps to Reproduce (for bugs)

  1. Build Assembler from Immersive Engineering
  2. Use a recipe that is gated behind anything in Age 1 or beyond

Context

When using the assembler from Immersive Engineering to auto craft items, it would seem that the recipes that are gated behind stages are not craftable: IE, Iron Sheet Metal slabs to blocks where as sheet metal slabs are craftable at any stage..

Client Information

  • Modpack Version: 3.0.6
  • Java Version: 1.8.0_91
  • Launcher Used: Twitch App
  • Memory Allocated: 6GB
@artdude543
Copy link
Contributor

@BluSunrize or @malte0811 is there anything that could be done in regards to this? Like, take the player name of who built the structure? I don't think there could be a way to use a custom player name for highest progression as then we'd need a way to change an internal name in the mod.

But the player name taking sounds like a more objective way of solving this solution maybe?

@BluSunrize
Copy link

We don't really account for that, no. The assembler just goes through available recipes, factoring in a player has never been necessary...

@artdude543
Copy link
Contributor

Yeah; I never thought about this issue could be a thing as other crafters in the pack are going to have the same issue in regards to the fake player being stuck at Age 0. I'm not too sure on what could be done in regards to this as this is out of my knowledge range for modding.

@DerpityDoo
Copy link

DerpityDoo commented Apr 14, 2018

If no better solution can be found then you could just gate a different crafter to each age, assuming they don't all use the same "fake player".

@BluSunrize
Copy link

Oh so your problem is being stuck in Age 0. I thought you had the issue of people craftign stuff too advanced :'D (I didn't read this well this morning)

If you've got a decent idea how to handle this, I'd want to look into it. But I'm not sure a player's name is enough? I don't know how SevTech's gating system works, and I can't store the whole player data...

@artdude543
Copy link
Contributor

artdude543 commented Apr 14, 2018

@Darkhax as you created the GameStages Mod; What would your input/ideas on this issue? Or in general, what'd you think could be done to help resolve.

@Darkhax
Copy link
Contributor

Darkhax commented Apr 15, 2018

This would be the area of RecipeStages which is done by @jaredlll08. That said, for this to work, the TileEntity would need to pass a player instance which has the stages unlocked with our API. In GameStages itself there are some areas of the code which will also fail on fake players, which was partially intended but doesn't need to be.

I've been discussing a refactor of the GameStages API for a while now that will potentially break compat with some addons. Perhaps Blu and some others could help me work out a way to add stage support to tile entities and fake players.

cpw added a commit to cpw/Game-Stages that referenced this issue Apr 21, 2018
This should mean that gamestages are much more compatible with automated
miners and such.

You could probably provide a config to whitelist specific fakeplayer ids
rather than all. The only call that won't work is "getAllStages" since
that's not a globally stored list.

This would likely address issues DarkPacks/SevTech-Ages#1733 and DarkPacks/SevTech-Ages#1803
@M3wM3w
Copy link

M3wM3w commented Apr 21, 2018

Please.. want to make an assembler cake factory so bad >.>

@codewarrior0
Copy link

codewarrior0 commented Apr 23, 2018

First, I tried to work around this by adding stages to the Assembler's container gui by adding this to containers.zs:

//Immersive Engineering Assembler
mods.recipestages.Recipes.setPackageStage("blusunrize.immersiveengineering.common.util.Utils$InventoryCraftingFalse$1", [STAGES.tutorial, STAGES.baykok, STAGES.zero, STAGES.one, STAGES.two, STAGES.three]);

Then, I found something else:

@BluSunrize I debugged the hell out of this and found AssemblerHandler.findAdapterForClass isn't finding an adapter for RecipeStage. Thoughts?

@ghost
Copy link

ghost commented May 15, 2018

Any way to fix it in private server? (grant all advancements to this fake player)?

@Jandakast
Copy link
Contributor

No, the Assembler isn't even a fake player, it's a container and attempting to stage the container hasn't worked. We are still looking into it and will fix it once we can.

@sam-kirby
Copy link
Contributor

This issue is fortuitously resolved by BluSunrize/ImmersiveEngineering@1ba6025 so long as the container is given the relevant stages.

@DarkPacks DarkPacks unlocked this conversation May 10, 2019
sam-kirby added a commit that referenced this issue May 10, 2019
* Specify correct package for the Inductive Logistics Autocrafters' container
* Add immersive engineering package in preparation for 0.12-90 (no effect until update included) see #1803
sam-kirby added a commit that referenced this issue May 12, 2019
* Specify correct package for the Inductive Logistics Autocrafters' container
* Add immersive engineering package in preparation for 0.12-90 (no effect until update included) see #1803
@Dominic1DL
Copy link

Dominic1DL commented Nov 1, 2019

IE is at 0.12-92 please update to finaly fix this Issue

@sam-kirby sam-kirby added this to the 3.1.* (Patch) milestone Nov 2, 2019
@Squ-Cog

This comment has been minimized.

@DarkPacks DarkPacks locked as resolved and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests