Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

gh articles use light background color #96

Closed
tessus opened this issue Oct 17, 2019 · 4 comments · Fixed by #98
Closed

gh articles use light background color #96

tessus opened this issue Oct 17, 2019 · 4 comments · Fixed by #98
Labels
Accepted This issue or PR has been accepted to undergo fix or review Shipped Solution for this issue has been shipped
Milestone

Comments

@tessus
Copy link
Contributor

tessus commented Oct 17, 2019

Describe the bug

Go to a gh article, e.g.: https://help.github.com/en/articles/set-up-git
Top left and right corner are white (or close to white #fafbfc).
Responsible code: <div style="background:#fafbfc;">

Expected behavior

The background should be like the rest of the page.

Screenshots

image

Desktop (please complete the following information):

  • Theme version: 1.14.1
  • Browser: Firefox 69.0.3 (macOS)
@Snazzie
Copy link
Member

Snazzie commented Oct 17, 2019

you're right, though id probably make the whole top bar #24292E so its consistent to the rest of the theme.

@Snazzie Snazzie added the Accepted This issue or PR has been accepted to undergo fix or review label Oct 17, 2019
@tessus
Copy link
Contributor Author

tessus commented Oct 17, 2019

Sure, whatever works to get rid of those white corners ;-)

@Snazzie
Copy link
Member

Snazzie commented Oct 17, 2019

if you wish to get rid of it right now, just edit the theme and add the following

div[style="background:#fafbfc;"] {
	background: unset !important;
}

I probably won't be releasing the fix until sunday :^)

@Snazzie Snazzie added this to the 1.15 milestone Oct 17, 2019
@tessus
Copy link
Contributor Author

tessus commented Oct 18, 2019

No worries, no rush. I don't read gh articles very often. It's just something I've noticed.

@Snazzie Snazzie mentioned this issue Oct 20, 2019
Merged
@Snazzie Snazzie added the Shipped Solution for this issue has been shipped label Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accepted This issue or PR has been accepted to undergo fix or review Shipped Solution for this issue has been shipped
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants