Support plain request query parameters #86
+74
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibradwan
force-pushed
the
ibradwan/support-plain-query-parameters
branch
from
79b3e06
to
dc74213
Compare
|
@DarkWanderer Would you please approve the remaining checks? |
|
@DarkWanderer Would you mind reviewing this PR? |
|
Please let me know if you would prefer to change something in this PR s.t. I can work on that 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Feature/Enhancemet (#79).
Description:
Support adding and removing plain HTTP query parameters on the
IClickHouseCommandlevel. These query parameters are sent as is in the request to the ClickHouse server.