fix: Dissolve more CMake dependencies #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiphoseer
force-pushed
the
fix/cmake-libs-2
branch
2 times, most recently
from
1609348
to
bde8d9b
Compare
EmosewaMC
reviewed
Jan 5, 2024
Xiphoseer
force-pushed
the
fix/cmake-libs-2
branch
from
eb4c6b6
to
665ee98
Compare
Xiphoseer
force-pushed
the
fix/cmake-libs-2
branch
from
97a27f8
to
6fb88e7
Compare
|
This PR is still not cleaned up completely, but please help review and test it. |
|
tested that it builds on my local dev laptop (manjaro) and a test server (Ubuntu 18.04) |
Jettford
previously approved these changes
Jan 6, 2024
EmosewaMC
reviewed
Jan 6, 2024
EmosewaMC
force-pushed
the
fix/cmake-libs-2
branch
from
dc22fa9
to
247b88d
Compare
Will fix in another PR.
|
Merge from upstream will resolve the current build failure. |
remove 2 more included directories. remove commented out code add status to messages
EmosewaMC
reviewed
Mar 4, 2024
surround include directories with quotes remove commented out code remove debug messages
aronwk-aaron
previously approved these changes
Mar 4, 2024
aronwk-aaron
approved these changes
Mar 5, 2024
jadebenn
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (arguably?) improves the CMake setup a bit. A bunch of folders are now
OBJECTlibraries and more cmake code was moved to thecmakefolder. The global include list has been cut down, and each library now needs to opt in what other libraries to compile against.Beware that circular dependencies on static libs are possible, but discouraged and can lead to pathological cases when cmake tries to figure out in what order to execute them and may end up with no parallelism at all.