chore: Change entity and component logic to use bitstream references #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwk-aaron
previously approved these changes
Feb 25, 2024
EmosewaMC
previously approved these changes
Feb 26, 2024
|
Quest givers, vendors, combat, and general game play functioned normally over about an hour of game play following the main quest line from AG to NS to GF. |
|
...though it looks like I will have to manually resolve some branch conflicts before I can merge later today |
jadebenn
dismissed stale reviews from EmosewaMC and aronwk-aaron
via
8482460
aronwk-aaron
approved these changes
Feb 27, 2024
EmosewaMC
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to references from raw pointers.
Note: For your sanity, there are no unrelated changes in this or the other PRs. I specifically want to make that clear here given the sheer volume of files touched. The only changes included are those needed to make these pointers references. I have done my absolute best to keep these chunks as small as possible, but this one is huge despite my best efforts.