Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Convert DoClientProjectileImpact to use bitstream refs #1471

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore: Convert DoClientProjectileImpact to use bitstream refs #1471

merged 1 commit into from
Feb 27, 2024

Conversation

jadebenn
Copy link
Collaborator

raw pointer reduction

EmosewaMC
EmosewaMC approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was covered in your other testing, can you just drop that comment here as well so its documented what was tested

@jadebenn
Copy link
Collaborator Author

Does the Space Ranger kit weapon count as a projectile? I'll try and test with another gun if it doesn't.

@jadebenn
Copy link
Collaborator Author

confirmed that guns still do the shooty-hurty

@jadebenn jadebenn merged commit 4b0079c into main Feb 27, 2024
4 checks passed
@jadebenn jadebenn deleted the ProjectileImpactBitStreamRefs branch February 27, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aronwk-aaron aronwk-aaron aronwk-aaron approved these changes

@EmosewaMC EmosewaMC EmosewaMC approved these changes

@Jettford Jettford Awaiting requested review from Jettford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jadebenn @aronwk-aaron @EmosewaMC