feat: move all ldf config to be in xml #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanup dev-tribute.xml add comments to atm.xml remove custom script tag in favor of ldfconfig for it
|
converted all xml files from spaces to tabs as well |
jadebenn
reviewed
Feb 27, 2024
jadebenn
reviewed
Feb 27, 2024
jadebenn
reviewed
Feb 27, 2024
jadebenn
previously requested changes
Feb 27, 2024
EmosewaMC
reviewed
Feb 27, 2024
EmosewaMC
reviewed
Feb 27, 2024
EmosewaMC
reviewed
Feb 27, 2024
Jettford
previously approved these changes
Feb 27, 2024
|
(tweaking some more vanity xml stuff currently in discord) |
|
PR done, wont touch it anymore besides feedback |
I'm afraid the merge conflict says otherwise 😜 |
jadebenn
reviewed
Feb 28, 2024
aronwk-aaron
force-pushed
the
moreVanityCleanup
branch
from
244a6b6
to
ab1fa4f
Compare
jadebenn
approved these changes
Feb 28, 2024
EmosewaMC
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup dev-tribute.xml
add comments to atm.xml
remove custom script tag in favor of ldfconfig for it
Add default client script to be defined in xml rather than a hardcoded special case
Use generic config option for random spawning rather than specifically teleport
Tested that everything loads still
Tested that things talk when they should
Tested that avery still teleports