chore: Table Loading Improvements #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmosewaMC
reviewed
Mar 4, 2024
EmosewaMC
requested changes
Mar 4, 2024
There was a problem hiding this comment.
good improvements to construction of objects in containers. As you know unnecessary copies are good to remove. The pet component changes can be moved to their own pr (small enough to anyways and arent really related to any code changes here) and the .at revert is necessary as the table was complete before as far as functionality goes, and this change will cause crashes when they are not necessary.
dDatabase/CDClientDatabase/CDClientTables/CDPackageComponentTable.cpp
Outdated
Show resolved
Hide resolved
dDatabase/CDClientDatabase/CDClientTables/CDPhysicsComponentTable.cpp
Outdated
Show resolved
Hide resolved
aronwk-aaron
changed the title
|
Updated to account for feedback |
|
Discovered an issue with this branch (#1493). Recommend holding off on review until I have time to fix. |
jadebenn
commented
Mar 6, 2024
EmosewaMC
previously approved these changes
Mar 6, 2024
aronwk-aaron
approved these changes
Mar 6, 2024
EmosewaMC
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make more use of emplace() in some of the CDClient tables