chore: Less verbose name for enum underlying type casts #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmosewaMC
previously approved these changes
Mar 6, 2024
EmosewaMC
reviewed
Mar 6, 2024
aronwk-aaron
previously approved these changes
Mar 6, 2024
aronwk-aaron
approved these changes
Mar 7, 2024
EmosewaMC
approved these changes
Mar 7, 2024
|
Have you tested that you can still login (and fail to login) |
|
Logins work normally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having actually needed to use this helper function fairly extensively for a commit on the PetFixes branch, I propose switching it to use a slightly shorter name that's still descriptive