fix: Remove multiple Script syntax #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwk-aaron
approved these changes
Mar 6, 2024
aronwk-aaron
approved these changes
Mar 6, 2024
jadebenn
reviewed
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squashed and rebased from #1489
The client physically does not support having multiple scripts on a GameObject. This PR seeks to remove implying the possibility of this being a thing.
tested:
entering, playing and leaving avant gardens survival (single player, played start to finish)
Using pirate hook build (OnStartup)
red blocks smashables cycle (OnDie, OnQuickbuildComplete)
spider queen instance battle functions from start to finish (OnStartup, ondie, otimer done, OnHitOrHealResult, OnUpdate)
entering fv for the first time (OnPhantomCollision)
building fv canister for blue brick (notifyObject)
boogie down functions (onemote received)
property tutorial missions (OnZonePropertyModelRotated, OnZonePropertyModelRemovedWhileEquipped, OnZonePropertyModelRemoved, OnZonePropertyModelPickedUp, OnZonePropertyModelPlaced, OnZonePropertyModelEquipped, OnZonePropertyEditBegin, OnZonePropertyEditEnd)
growing flowers on crux (OnSkillEventFired)
Imaginite pack (OnHit)
damaged by fire (OnPhantomCollision, OnOffPhantomCollision)
building both consoles fv (OnQuickbuildNotifyState)
Mast teleporting (OnQuickBuildComplete)
fans in ag turn off and on (OnFireEventServerSide trigger)
naxue naomi breadcrumbs mission (OnMissionDialogueOK)
nexus jay join faction mission (OnRespondToMission)
build rocket for mardolf the orange (OnModularBuildExit)
Using a ninjago ice rail activator in caves (OnPlayerRailActivated)