chore: supress warnings on external library headers and actually get rid of the last old-style casts #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rid of the last old-style casts
|
What are alternative solutions that do not involve upgrading cmake? |
|
I couldn't figure out another way to get the SYSTEM flag consistently applied to the the dependencies. If there's a way to do that, it would avoid the issue. |
EmosewaMC
reviewed
Mar 15, 2024
aronwk-aaron
previously approved these changes
Mar 17, 2024
|
please update the readme as well |
aronwk-aaron
approved these changes
Mar 18, 2024
EmosewaMC
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding the 'SYSTEM' keyword to subdirectories is actually a relatively new CMake feature from what I gather, so it might be worthwhile to discuss bumping up the required version in the main CMakeLists.txt as I'm not sure how this would interact with older versions