Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor slash commands system into more scalable system #1510

Merged
merged 19 commits into from
Apr 8, 2024

Conversation

aronwk-aaron
Copy link
Member

@aronwk-aaron aronwk-aaron commented Mar 25, 2024

Spot checked a several of the commands.
Things still work and there is a new help command.
A bulk of the changes are breaking up the big if-else-if block into functions and registering each command.

Future PR will break out each set of command into it's own file. (dev, gm zero, and gm greater than zero command)

@aronwk-aaron
Copy link
Member Author

Note to self: fix failing test

idk how these werent failing before.  Seems to have been magic.
@aronwk-aaron
Copy link
Member Author

Note to self: fix failing test

Thanks emo

@aronwk-aaron aronwk-aaron marked this pull request as ready for review April 3, 2024 04:55
@aronwk-aaron
Copy link
Member Author

OKAY, this is the final form of this PR, I need to check some things with the help command not displaying correctly in-game that may be due to some char limit of that message, but that's a tangent.
General feedback and suggestions welcome. Emo help me with this impl, so I may need to refer to him for some questions

@EmosewaMC EmosewaMC removed their request for review April 3, 2024 06:04
@EmosewaMC
Copy link
Collaborator

Declining to review since I contributed to the pr and am biased. I will keep cleaning it up and helping work on it though

pass through added code for optimizations and cleanup as well as reduce the amount of scoping for readability and maintainability
@EmosewaMC
Copy link
Collaborator

EmosewaMC commented Apr 3, 2024

text prints correctly and utilizes the asterisk found in reverse engineering. Its used for denoting where a localized string starts and ends.

Edit: I see the weirdness... not sure why its repeating the last chunk of text for large strings

@EmosewaMC
Copy link
Collaborator

afaict, we are sending the correct data, however whats being printed is not correct. Will have to debug further to figure out the issue.

@EmosewaMC
Copy link
Collaborator

EmosewaMC commented Apr 4, 2024

gmlevel 0, 9, 7, 9, 0 sets my gm level to the correct value
makegm and setgmlevel both set the gm level as above
togglenameplate is locked out when disabled still, gm bypasses.
reloadconfig works
toggleskipcinematics is toggleable on and off and the config option still locks it to gms or civilians if enabled for them
resetmission still works
addmission still works
completemission still works
setminifig works
gminvis works
unlockemote works
playanim works
listspawns works
forcesave works
kill works
speedboost works
freecam works
setcontrolscheme works
setuistate works
toggle works
setinventorysize works
runmacro works
setflag and setflag on/off work
clearflag works
stopeffect and playeffect work
setanntitle setannmsg announce all work
shutdownuniverse works
getnavmeshheight works
gmadditem works
teleport with 2 and 3 args works
tpall works
dismount works
buffme and buffmed works
startcelebration works
refillstats works
lookup works
spawn works
spawngroup works
giveuscore and setlevel works
pos rot locrow works
setcurrency freemoney works
playlvlfx playrebuild fx works
buff works
testmap works
createprivate works
debugui works
boost works
unboost works
activatespawner works
spawnphysicsverts works
reportproxphys works
triggerspawner works
reforge works
metrics works
reloadconfig works
rollloot works
deleteinven works
castskill works
setskillslot works
setfaction works
addfaction works
setrewardcode works
inspect 2 -s works
kick works
ban works
mailitem works
approveproperty works
fly works
attackimmune works
gmimmune works
gminvis "works"
setname works
title works

EmosewaMC
EmosewaMC previously approved these changes Apr 7, 2024
Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished a code passthrough. Don't see anything missed on my end, but will not be explicitly approving as I contributed to the PR.

@EmosewaMC EmosewaMC dismissed their stale review April 7, 2024 09:39

mis-click

Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished a code passthrough. Don't see anything missed on my end, but will not be explicitly approving as I contributed to the PR.

Copy link
Member

@DarwinAnim8or DarwinAnim8or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props for actually undertaking this :')

Copy link
Collaborator

@Jettford Jettford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny note, completely non-blocking (presuming it isn't a dumb comment to begin with). Awesome stuff other than that.

dWorldServer/WorldServer.cpp Show resolved Hide resolved
@aronwk-aaron aronwk-aaron merged commit feeac2e into main Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants