fix: more restrictive std::from_chars for floating point #1524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given that fp is only on 2 compilers, it would make sense to only do the custom impl for not those two compilers.
Still compiles on my machine which has gcc-11 and does not error if I insert an error macro inside the if block.
![image](https://private-user-images.githubusercontent.com/39972741/318301388-538e3bb4-a976-44e2-9a14-95de528eee07.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1Mzk5NTUsIm5iZiI6MTcxOTUzOTY1NSwicGF0aCI6Ii8zOTk3Mjc0MS8zMTgzMDEzODgtNTM4ZTNiYjQtYTk3Ni00NGUyLTlhMTQtOTVkZTUyOGVlZTA3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAxNTQxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzYTBhZGJiYTM3YjhkZmI2NzQyNDJlMTkyMmM1MDZhNDJkMzRlOTk4YWZjMTg2YTQ2MzFkNGMyNDJiN2NiMTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XqFI7NXTES9ATTdrAAhh9jbVdYF7QZSJf9F4typGjwY)