Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove dpEntity pointers from collision checking #1529

Merged
merged 9 commits into from
Apr 5, 2024

Conversation

jadebenn
Copy link
Collaborator

@jadebenn jadebenn commented Apr 4, 2024

Fixes #1522. Tested by going into AG and checking that the bus raises and lowers in the Sentinel base

aronwk-aaron
aronwk-aaron previously approved these changes Apr 4, 2024
dPhysics/dpEntity.cpp Outdated Show resolved Hide resolved
dPhysics/dpEntity.cpp Outdated Show resolved Hide resolved
dScripts/ai/AG/AgBusDoor.cpp Outdated Show resolved Hide resolved
aronwk-aaron
aronwk-aaron previously approved these changes Apr 4, 2024
Copy link
Member

@Wincent01 Wincent01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing currently colliding to a set is required, the other things are nitpicks

dGame/dComponents/PhantomPhysicsComponent.cpp Outdated Show resolved Hide resolved
dGame/dComponents/PhantomPhysicsComponent.cpp Outdated Show resolved Hide resolved
dPhysics/dpEntity.h Outdated Show resolved Hide resolved
@jadebenn jadebenn merged commit 06e7d57 into main Apr 5, 2024
4 checks passed
@jadebenn jadebenn deleted the physics-id-refactor branch April 5, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Remove usage of dpEntity objects being used for collision checks
4 participants