-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use string to access SQLite columns #1535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably wouldn't be a measurable improvement, but we could utilize static variables to store a cashed index of the fields.
I was planning on doing more improvements in a separate PR. this one is mostly just a number->text replacement and ideally any queries to the cdclient are replaced with an ORM table for caching |
tested the following |
lookup still works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicks aside, looks good. you can address them if you want, or don't if you don't
well, frick |
c2a548a
to
5c2b305
Compare
Untested right now. Will try to test later. May do some other small improvements near this code, like removing finalizes and some char* -> string -> copy to data stuff, may not. idk atm.fixes #1531