This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
change method of comparison #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as a note it will crash the game if the format isnt correct, aka missing the "_" it will crash the game if the format isnt correct, aka if the "version" isnt a number
|
it doesnt crash anymore because i made the checks |
|
Could this be merged and published |
|
This pr is very useful to prevent users from using Curseforge's old java,let's merge it. |
Krutoy242
added a commit
to Krutoy242/Enigmatica2Expert-Extended
that referenced
this pull request
May 30, 2023
Now, if player launch game from CurseForge launcher with 7-year-old Java, they will be warned. Implement Darkhax-Minecraft/OldJavaWarning#9 https://i.imgur.com/OfIfrWz.png
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice that when you use CurseForge with a java version 51, it never triggers the message about a old java
What happens is that the version printed is 1.8.0_51, when you compare with 1.8.0_162, it will tell you the 51 is higher than 162
So i splited the version into a array, and converted the second value to integer in order to do a better check
as a noteit will crash the game if the format isnt correct, aka missing the "_"
it will crash the game if the format isnt correct, aka if the "version" isnt a number
those 2 can be prevented with some more modifications