-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Node container errors #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this error
node_1 | yarn install v1.12.1
node_1 | info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
node_1 | errorinstall
has been replaced withadd
to add new dependencies. Run "yarn add && yarn encore dev" instead.
If I use the node:latest image (in the docker-compose.yml), everything's fine for me. Perhaps, it's better to change the tag of the node image we're using. What do you think @lbassin ? |
I agree to use node:latest, this tag is just bigger but it shouldn't be an issue in this case What should we do about others dockerfile ? |
I agree to put everything in a docker folder. I think Delphine did that but @tdutrion asked her to put everything at the root. Don't know why :-) |
Considering this subject isn't related to the node container i am going to open an new issue to talk about it We can merge this PR if everything is ok for you @cgrandval |
This PR resolves #28
I changed default command of the node container and add missing packages
With this PR we'll be able to successfully build our js and scss