Brochure pdf #75
Merged
Brochure pdf #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbassin
suggested changes
Dec 18, 2018
ayumiesan
force-pushed
the
brochure-pdf
branch
2 times, most recently
from
12f1e13
to
f2db833
Compare
lbassin
previously approved these changes
Dec 24, 2018
|
Looks good for me |
ayumiesan
force-pushed
the
brochure-pdf
branch
from
947101b
to
97b1308
Compare
tdutrion
approved these changes
Jan 11, 2019
| public function create(): void | ||
| { | ||
| $this->pdf = new Html2Pdf($this->orientation, $this->format, $this->lang, $this->unicode, $this->encoding, $this->margin); | ||
| $this->pdf->setTestIsImage(false); |
There was a problem hiding this comment.
Is that necessary? I remember it's needed in some cases but can't remember exactly when... Sounds like it can allow problems though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #37
Generate the brochure Pdf with :