Limbus Cosmo Cleanse and Card

[m241dan]

Limbus only calling onBCNMEnter for the initiator, so others arent getting card and cleanse removed.

[nesstea]

It's also allowing a person to do Omega/Ultima over and over if they turned in the chips.

[TeoTwawki]

Lamebus pretty much needs some overhauling to rewrite large parts of it. In one script its even calling a feature that was deprecated from lua before DSP was even a twinkle in anyone's eye and the core bits for battlefield entry recreate functionality that already existed just to unnecessarily enforce some specific instance IDs for what were already entirely separate battlefield IDs and call them special - the whole of limbus is just bad (even worse than the current dynamis implementation, if that tells you anything).

[Hozu]

@nesstea I never had infinite Ultima access, or infinite access to any of Temenos 1-3F - only Omega. I remember having to do some stupid hotfix that someone else wrote and I didn't understand why it worked out so I never contributed it here.

[nesstea]

@Hozu would you be willing to share/find such fix?

[Hozu]

Uh, I forget what I did, sorry. You might be able to find it in a fairly old (within past year) pull that didn't get merged.

[takhlaq]

you mean this #1592 ?

[Hozu]

That's it, yeah.

[nesstea]

I'll test it out right now.

[nesstea]

It does stop the multiple chips from dropping but it doesn't fix the previous issue I stated above.

[Hozu]

Well yeah, I never said it did that, heh. All BCNMs that require everyone to have access doesn't check the other players - stuff like prime avatar fights. You can get Fenrir without having fought any prime avatars, for instance.

[TeoTwawki]

We have both getParty() and getAlliance() now so should all be fixable with the addition of a loop to remove what is needed from the other members.

[teschnei]

You don't lose your entry item until you enter

On Tue, Dec 22, 2015 at 7:38 PM, TeoTwawki notifications@github.com wrote:

We have both getParty() and getAlliance() now so should all be fixable
with the addition of a loop to remove what is needed from the other
members..

—
Reply to this email directly or view it on GitHub
#2459 (comment)
.

[teschnei]

nobody tried, probably

On Tue, Dec 22, 2015 at 8:36 PM, TeoTwawki notifications@github.com wrote:

And we can't do this on entry because...?

—
Reply to this email directly or view it on GitHub
#2459 (comment)
.

[Hozu]

Oh yes, this is pretty obvious but there needs to be a distinction between BCNMs that require everyone to have the requirements, and the ones that don't. I don't know if that currently exists or not.

[nesstea]

@TeoTwawki did you write any documentation for your getParty/alliance functions? I don't know what they return exactly.

[takhlaq]

they return a table of entities
in alliance, all you would change is getParty() to getAlliance()
iterate through as you would any other lua table to get the member e.g.

local party = player:getParty();
for _, member in pairs(party) do
    member:doShit();
end;

[TeoTwawki]

After talking with Kj in IRC...We probably don't even need to use them, limbus just probably isn't checking for anything except the bcnm status when you enter. Which makes it even more stupid a bug than I initially thought.

You'd use getParty/getAlliance to do things to everyone when 1 person clicks something though.

@xdemolish yer example is off bud. Gotta check nil

    local party = player:getParty();
    if (party ~= nil) then -- can actually be nil
        for hey, dude in pairs(party) do
            dude:doStuff();
        end
    end

darkstar/scripts/zones/Bhaflau_Thickets/npcs/_1g2.lua

Line 65 in 28a96bc

if (party ~= nil) then

Edit: things I forgot to finish and looking in the wrong local copy for the win?

[Hozu]

Nah it checks if the other players have the two KIs when they try to enter - I've known people to be locked out when they have no soap. It simply doesn't remove them.

[TeoTwawki]

@Hozu I mean at the point it moves you in, not the point where it decided you are eligible to go in. Even if that looks like a single step form a player perspective.

[Kushdr]

I think I fixed this and #2879 locally. I can submit later for review

[TeoTwawki]

open new issue if this is still happening