Fix #11. Improve preprocessor parsing #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now preprocessor directives are lexed properly. The parser just adds all tokens after a preprocessor directive until the next newline to the PSI element.
Currently parsed and highlighted correctly:
Not yet implemented:
#if
/#ifdef
/#ifndef
with the matching#else
/#end
. They're currently just parsed as two independent directives.#version
and#extension
to set properties on theGLSLFile
, to be used for error annotation and autocompletion#define
to actually define tokens, which are then inserted into the token stream when coming across them inadvanceLexer
#if
/#ifdef
/#ifndef
to be evaluated properly (this would require some constant expression analysis).