Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix membership tests (add -and) #242

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix membership tests (add -and) #242

merged 1 commit into from
Feb 25, 2020

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Feb 21, 2020

PR Summary

Membership tests lack "-and" operator. I did occasionally get wrong results like this:

Context Test-VSTeamMembership
      [-] Should test membership 18ms
        Expected Invoke-RestMethod in module VSTeam to be called 1 times exactly but was called 2 times
        22:             Assert-MockCalled Invoke-RestMethod -Exactly 1 -ParameterFilter {
        at <ScriptBlock>, C:\MIZE\DEV\GitHub\vsteam\unit\test\membership.Tests.ps1: line 22

PR Checklist

(No need for those)

Copy link
Collaborator

@SebastianSchuetze SebastianSchuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks!

@DarqueWarrior do these kinds of changes require a new patch version?

@DarqueWarrior
Copy link
Collaborator

We will just roll them into the next release.

@DarqueWarrior DarqueWarrior merged commit 5e83d41 into MethodsAndPractices:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants