New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security cmdlet Improvements and added Add-VSTeamBuildPermission #386

Merged

SebastianSchuetze merged 6 commits into MethodsAndPractices:trunk from RazorSPoint:topic/SecurityImprovmentsAndPermissions

Jun 25, 2021

Collaborator

SebastianSchuetze commented Mar 8, 2021 •

edited

Loading

PR Summary

added the cmdlet Add-VSTeamBuildPermission following the other cmdlet like Add-VSTeamProjectPermission
changed internal functions to not have deny or allow permissions to be mandatory, because this caused not to be able to only add allow or deny permissions.
allowed to handle user accounts from typ 'srv' which are service accounts of Azure DevOps. Now these can be permitted as well to all functions using ACLs

PR Checklist

SebastianSchuetze added 2 commits

March 8, 2021 16:22


          - made deny and allow mask non mandatory

fbbb94a

- added ability to resolve service identity descriptor
- added cmdlet Add-VSTeamBuildPermission


          fixed added service identity descriptor return

61a8973

SebastianSchuetze commented

View reviewed changes

Source/Public/Add-VSTeamBuildPermission.ps1 Outdated Show resolved Hide resolved

SebastianSchuetze commented

View reviewed changes

Tests/function/tests/Add-VSTeamBuildPermission.Tests.ps1 Outdated Show resolved Hide resolved

SebastianSchuetze commented

View reviewed changes

Tests/function/tests/Add-VSTeamBuildPermission.Tests.ps1 Outdated Show resolved Hide resolved

SebastianSchuetze commented

View reviewed changes

Tests/function/tests/Add-VSTeamBuildPermission.Tests.ps1 Show resolved Hide resolved

SebastianSchuetze commented

View reviewed changes

Collaborator Author

SebastianSchuetze left a comment

some changes for my own code.

SebastianSchuetze added 4 commits

June 24, 2021 17:40


          Apply suggestions from code review

43141cb


          Merge branch 'trunk' into topic/SecurityImprovmentsAndPermissions

0ae545c


          Merge remote-tracking branch 'upstream/trunk' into pr/RazorSPoint/386

de3b6bd


          added changes to the change log

40efbed

SebastianSchuetze merged commit 9588413 into MethodsAndPractices:trunk

SebastianSchuetze deleted the topic/SecurityImprovmentsAndPermissions branch

June 25, 2021 09:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet