Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move flutter_lints to dev_dependencies #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacksoncurrie
Copy link

Due to the flutter_lints package being in the dependencies many people will get version conflicts.

flutter_lints is only used in development so doesn't need to be shipped with this package. This will solve conflicts for all versions going forward and can be updated internally at any stage to fit project needs.

Moving to dev_dependencies: is also recommended by the flutter team when using flutter_lints as seen here.

@wilpar
Copy link

wilpar commented Aug 5, 2022

This works until 3.0.2. 3.0.3 is blocked on flutter_lints ^2.0.1

Because XXX depends on geoflutterfire ^3.0.3 which depends on flutter_lints ^1.0.0, flutter_lints ^1.0.0 is required.
So, because XXX depends on flutter_lints ^2.0.1, version solving failed.

@jacksoncurrie
Copy link
Author

This works until 3.0.2. 3.0.3 is blocked on flutter_lints ^2.0.1


Because XXX depends on geoflutterfire ^3.0.3 which depends on flutter_lints ^1.0.0, flutter_lints ^1.0.0 is required.

So, because XXX depends on flutter_lints ^2.0.1, version solving failed.

But if we move it to dev_dependencies geoflutterfire will not depend on flutter_lints at all when used in projects.

@jacksoncurrie
Copy link
Author

Same Issue Again So, because xx depends on flutter_lints ^2.0.1, version solving failed.

You'll want to see what depends on flutter_lints: ^2.0.1. This should always be in dev_dependencies, and only in your app. Any other dependencies should remove this from their dependency list.

@jacksoncurrie
Copy link
Author

I noticed that this is also fixed in PR #197, so if that gets merged, this can be dismissed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants