Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging doesn't work in 1.19.0-dev.7.3 SDK #129

Closed
DanTup opened this issue Aug 25, 2016 · 4 comments
Closed

Debugging doesn't work in 1.19.0-dev.7.3 SDK #129

DanTup opened this issue Aug 25, 2016 · 4 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Aug 25, 2016

Using 1.19 RC SDK.

Code:

main() {
  print("test");
}

Press F5 to run under debugger; program never runs. Logged output is:

==> {"id":"0","method":"streamListen","params":{"streamId":"Isolate"}}
==> {"id":"1","method":"streamListen","params":{"streamId":"Debug"}}
<== {"jsonrpc":"2.0","id":"0","result":{"type":"Success"}}
<== {"jsonrpc":"2.0","id":"1","result":{"type":"Success"}}

Whereas in 1.18.1 we see:

==> {"id":"0","method":"streamListen","params":{"streamId":"Isolate"}}
==> {"id":"1","method":"streamListen","params":{"streamId":"Debug"}}
<== {"jsonrpc":"2.0","id":"0","result":{"type":"Success"}}
<== {"jsonrpc":"2.0","id":"1","result":{"type":"Success"}}
<== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Isolate","event":{"type":"Event","kind":"IsolateRunnable","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/243414459","name":"test.dart$main","number":"243414459"},"timestamp":1472205353653}}}
==> {"id":"2","method":"setExceptionPauseMode","params":{"isolateId":"isolates/243414459","mode":"Unhandled"}}
<== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"PauseStart","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/243414459","name":"test.dart$main","number":"243414459"},"timestamp":1472205353655}}}
==> {"id":"3","method":"resume","params":{"isolateId":"isolates/243414459"}}
<== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"_DebuggerSettingsUpdate","isolate":{"type":"@Isolate","fixedId":true,"id":"isolates\/243414459","name":"test.dart$main","number":"243414459"},"timestamp":1472205353657,"_debuggerSettings":{"_exceptions":"unhandled"}}}}

The 1.19 version never gets the IsolateRunnable event that came through in 1.18?

@DanTup DanTup added the is bug label Aug 25, 2016
@devoncarew
Copy link
Contributor

I don't know that the protocol has changed much recently. It's odd that the vm versions behave differently -

@DanTup DanTup changed the title Breakpoints in packages aren't correctly hit Debugging doesn't work in 1.19.0-dev.7.3 SDK Aug 26, 2016
@rmacnak-google
Copy link

I don't see a IsolateRunnable in 1.18.1 either. I think this is a usage error, with the intended usage being

  1. Subscribe to the isolate stream to learn about new isolates.
  2. Call getVM learn about the isolates that were already running.

@turnidge

@DanTup
Copy link
Member Author

DanTup commented Aug 26, 2016

Maybe this is a timing issue then? Maybe in 1.18.1 our subscription is being set up sooner? It's 100% reproducible for me though, those logs I posted are what I see for each version every time.

@DanTup
Copy link
Member Author

DanTup commented Aug 27, 2016

Confirmed fixed by #132 :)

@DanTup DanTup closed this as completed Aug 27, 2016
@DanTup DanTup modified the milestone: 0.10 Aug 27, 2016
@DanTup DanTup added the in debugger Relates to the debug adapter or process of launching a debug session label Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Projects
None yet
Development

No branches or pull requests

3 participants