Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize imports action moves ignore comments #1387

Closed
sestegra opened this issue Jan 13, 2019 · 1 comment
Closed

Organize imports action moves ignore comments #1387

sestegra opened this issue Jan 13, 2019 · 1 comment
Labels
upstream in dart / flutter Needs changing in Dart or Flutter

Comments

@sestegra
Copy link

sestegra commented Jan 13, 2019

Before calling Organize imports action, imports are as following:

// ignore: implementation_imports
import 'package:foo/src/foo_utils.dart';
import 'package:bar/bar.dart';

After calling Organize imports action, imports are as following:

import 'package:bar/bar.dart';
import 'package:foo/src/foo_utils.dart';
// ignore: implementation_imports

I suggest that comments with ignore should be considered as metadata annotation.

@DanTup
Copy link
Member

DanTup commented Jan 14, 2019

Thanks for the report! This behaviour comes from the SDK and it seems like there's an open issue describing exactly this case:

dart-lang/sdk#26728

I'll close this as a dupe - you may wish to subscribe and/or 👍 that issue. Thanks!

@DanTup DanTup closed this as completed Jan 14, 2019
@DanTup DanTup added the upstream in dart / flutter Needs changing in Dart or Flutter label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream in dart / flutter Needs changing in Dart or Flutter
Projects
None yet
Development

No branches or pull requests

2 participants