Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everytime when saving changes to pubspec.yaml asks if packages should be gotten #1988

Closed
escamoteur opened this issue Sep 13, 2019 · 3 comments
Labels
awaiting info Requires more information from the customer to progress in commands Relates to commands (usually invoked from the command Palette) is bug
Milestone

Comments

@escamoteur
Copy link

Normally this Dialog that asks should only appear when opening a project.

Currently if you have project with a nested example project it will query every time you change any pubspec file

@DanTup DanTup added this to the v3.5.0 milestone Sep 16, 2019
@DanTup DanTup added in commands Relates to commands (usually invoked from the command Palette) is bug labels Sep 16, 2019
@DanTup
Copy link
Member

DanTup commented Sep 17, 2019

I haven't been able to repro this - I have an example sub-folder, with a pubspec.yaml in it, but editing either pubspec only runs pub get for that particular project.

Anything else about your project that might be relevant? Does it repro if you run Dart: New Project , then copy paste a copy of itself into an example folder?

I tried it when example has no .packages or pubspec.lock files too, thinking that might trigger it, but I still see the same.

@DanTup DanTup added the awaiting info Requires more information from the customer to progress label Sep 17, 2019
@escamoteur
Copy link
Author

I just tried it again, it only happens when I open the project with a workspace.
This is the project https://github.com/escamoteur/rx_widgets where I see it

@DanTup DanTup closed this as completed in d9f319a Sep 17, 2019
@DanTup
Copy link
Member

DanTup commented Sep 17, 2019

Got it, thanks! It happens when you have a project that's in "two workspace folders" (here example is in its own, but also as a child of the parent folders workspace) so we found it twice, and thought there were multiple folders we needed to run for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting info Requires more information from the customer to progress in commands Relates to commands (usually invoked from the command Palette) is bug
Projects
None yet
Development

No branches or pull requests

2 participants