Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling "pub get" does not work #2612

Open
DanTup opened this issue Jul 7, 2020 · 2 comments
Open

Cancelling "pub get" does not work #2612

DanTup opened this issue Jul 7, 2020 · 2 comments
Labels
blocked on dart / flutter Requires a change in Dart or Flutter to progress in commands Relates to commands (usually invoked from the command Palette) is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Jul 7, 2020

  • Add an invalid package name in pubspec of a Flutter app
  • Click save
  • Open the Output window
  • Click Cancel on the "pub get" notification
  • Note the process continues to run (and there's no way to cancel it)
@DanTup DanTup added is bug in commands Relates to commands (usually invoked from the command Palette) labels Jul 7, 2020
@DanTup DanTup added this to the v3.13.0 milestone Jul 7, 2020
@DanTup
Copy link
Member Author

DanTup commented Jul 7, 2020

Adding this does not help:

if (this.process)
	this.process.kill();

I wonder if this is also related to dart-lang/sdk#42092, and may be fixed once that rolls into Flutter?

@DanTup
Copy link
Member Author

DanTup commented Jul 13, 2020

I think the code above is required, but it doesn't currently work due to flutter/flutter#61357. I'll leave it out until that's fixed so I can confirm it works correctly.

@DanTup DanTup added the blocked on dart / flutter Requires a change in Dart or Flutter to progress label Jul 13, 2020
@DanTup DanTup modified the milestones: v3.13.0, v3.14.0 Jul 28, 2020
@DanTup DanTup modified the milestones: v3.14.0, Backlog Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked on dart / flutter Requires a change in Dart or Flutter to progress in commands Relates to commands (usually invoked from the command Palette) is bug
Projects
None yet
Development

No branches or pull requests

1 participant