Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dart.customDevTools to support using "devtools_tool serve" instead of the old build_e2e script #4827

Closed
DanTup opened this issue Nov 7, 2023 · 0 comments
Closed

Update dart.customDevTools to support using "devtools_tool serve" instead of the old build_e2e script #4827

DanTup opened this issue Nov 7, 2023 · 0 comments
Labels
in devtools Relates to integration with Dart/Flutter DevTools is enhancement
Milestone
v3.78.0

Comments

@DanTup
Copy link
Member

DanTup commented Nov 7, 2023

Currently the dart.customDevTools setting assumes we will run dart ${dart.customDevTools.script} to start DevTools, but the script has been replaced by devtools_tool serve in flutter/devtools#6638

We should update this to just take a path to the DevTools repo root and run devtools_tool from within. Backwards compatibility with older DevTools is not a requirement, as this functionality exists purely for hacking on DevTools and we can assume anyone doing that is on the latest version.
@DanTup DanTup added this to the v3.78.0 milestone Nov 7, 2023
@DanTup DanTup mentioned this issue Nov 7, 2023
Closed
@DanTup DanTup added the in devtools Relates to integration with Dart/Flutter DevTools label Nov 7, 2023
@DanTup DanTup closed this as completed in 93f927d Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in devtools Relates to integration with Dart/Flutter DevTools is enhancement
Projects
None yet
Milestone
v3.78.0
Development

No branches or pull requests
1 participant
@DanTup