Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored implementation to support UWP and async #1

Closed
romanlum opened this issue Jun 25, 2017 · 3 comments
Closed

Refactored implementation to support UWP and async #1

romanlum opened this issue Jun 25, 2017 · 3 comments

Comments

@romanlum
Copy link
Contributor

I forked your repository and refactored the command processing using a queue, ported it to .NET Standard 1.4 and added a UWP Bluetooth implementation.

see https://github.com/romanlum/OBD.NET

If you like i can create a pull request.
@DarthAffe
Copy link
Owner

Hey, great work!
I'd love to merge that in, there's only one problem right now: I'm using this myself on a device running a quite old version of mono and I'm not 100% sure, if async/await is already supported there.
I'll test that in the next few days :)

@DarthAffe
Copy link
Owner

Hey, sorry for not getting back at this earlier.
I just tested it and it works great (the only change was to build it for .NET 4.5 which wasn't an issue). It would be great to see a pull-request for this :)

@DarthAffe
Copy link
Owner

Awesome! Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romanlum @DarthAffe