Rocm Backend: Fix regex for detecting version in Linux #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i'm trying out your library on my machine, but i can't use the ROCm backend on Linux
i'm using ArchLinux and rocm 6.0.2 (the version currently included in official arch repos)
The output from hipconfig is something like this:
...and so on.
As you can see HIP_PATH points to /opt/rocm, and it's not possible to find out rocm's version from there. but we can use the "HIP version" string just on top.
Also, the $ at the end makes the regex never match if there are other characters after the matched string, wich is not what we want.
I made a new regex wich takes the version from "HIP version"
also.... i'm not sure that checking just the major version is enough, but we can talk about that in another thread