Handle last line process output without new line end #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider process like `echo -n "text"`, it prints "text" without new line at the end and exit. Current overmind's output writer read from processes output pipe line by line and in this case it won't process "text" before overmind exit. Therefore we must ensure that lines passed to the output writer are always end with new line char.
|
well that fix have problems with long line outputs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider process like
echo -n "text", it prints "text" withoutnew line at the end and exit. Current overmind's output writer read
from processes output pipe line by line and in this case
it won't process "text" before overmind exit.
Therefore we must ensure that lines passed to the output writer
are always end with new line char. Fixes #81